Fix DoChannelOpen() and Add the regress test#919
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Apr 15, 2026
Merged
Fix DoChannelOpen() and Add the regress test#919JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens DoChannelOpen() handling for direct-tcpip forwarding by rejecting channel open requests when no forwarding callback is registered, and adds a regression test to ensure a CHANNEL_OPEN_FAILURE response is sent in that scenario.
Changes:
- Reject
direct-tcpipchannel opens inDoChannelOpen()whenssh->ctx->fwdCbis not set. - Add a regression test that sends a
direct-tcpipchannel-open without registeringfwdCband asserts an OPEN_FAILURE response.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/internal.c |
Adds explicit rejection behavior for direct-tcpip opens when forwarding callback is missing. |
tests/regress.c |
Adds a regression test covering the “no fwdCb registered” direct-tcpip open failure behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JacobBarthelmeh
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes DoChannelOpen() so that this rejects the request if no fwdCb is registered.
Also, this adds the regress test for the case.